I have a Xbone controller and a PS4 controller for my PC and I would recommend the Xbone pad by a mile. The PS4 controller took me over an hour to set up the first time, and every subsequent time it takes like 15 minutes just to get it working reliably. It’s a huge hassle. The Xbone pad is a great controller and just works. Plus pretty much every PC game these days is tuned for xbox style pads, with the buttons from it shown in the graphics and everything.
The only reason I’ve ever found it worth the trouble to connect my PS4 controller was when I was emulating PSX and PS2 games.